[
https://issues.apache.org/jira/browse/FLINK-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586155#comment-14586155
]
ASF GitHub Bot commented on FLINK-2093:
---------------------------------------
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-112099290
Hi @vasia ,
In essence the `difference` method is just a fancy way of removing
vertices, right?
When you remove a vertex, you also remove the edge for which it was a
source/target.
Since the add/remove vertices methods work just for lists and collect is
"unsafe", we mutually agreed to overload `removeVertices` to work for data
sets.
This way you would duplicate the least amount of code. Otherwise, you would
take the exact code in the DataSet removeVertices and duplicate it in
difference. That's not very practical IMO.
Also, it may occur that a user has a DataSet of elements to remove. An
extra removeVertices won't really hurt then, would it?
But if you have suggestions on how to improve this, we are more than eager
to hear about them :)
-Andra
> Add a difference method to Gelly's Graph class
> ----------------------------------------------
>
> Key: FLINK-2093
> URL: https://issues.apache.org/jira/browse/FLINK-2093
> Project: Flink
> Issue Type: New Feature
> Components: Gelly
> Affects Versions: 0.9
> Reporter: Andra Lungu
> Assignee: Shivani Ghatge
> Priority: Minor
>
> This method will compute the difference between two graphs, returning a new
> graph containing the vertices and edges that the current graph and the input
> graph don't have in common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
