[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187953#comment-16187953 ]
ASF GitHub Bot commented on FLINK-7072: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4742#discussion_r142103754 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.program.rest; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.JobManagerOptions; +import org.apache.flink.configuration.RestOptions; +import org.apache.flink.runtime.rest.RestClientConfiguration; +import org.apache.flink.util.ConfigurationException; + +/** + * A configuration object for {@link RestClusterClient}s. + */ +public final class RestClusterClientConfiguration { + + private final String blobServerAddress; + + private final RestClientConfiguration restEndpointConfiguration; + + private final String restServerAddress; + + private final int restServerPort; + + private RestClusterClientConfiguration( + String blobServerAddress, + RestClientConfiguration endpointConfiguration, + String restServerAddress, + int restServerPort) { + this.blobServerAddress = blobServerAddress; + this.restEndpointConfiguration = endpointConfiguration; + this.restServerAddress = restServerAddress; + this.restServerPort = restServerPort; + } + + public String getBlobServerAddress() { + return blobServerAddress; + } + + public String getRestServerAddress() { + return restServerAddress; + } + + public int getRestServerPort() { + return restServerPort; + } + + public RestClientConfiguration getRestEndpointConfiguration() { + return restEndpointConfiguration; + } + + public static RestClusterClientConfiguration fromConfiguration(Configuration config) throws ConfigurationException { + String address = config.getString(JobManagerOptions.ADDRESS); + + String serverAddress = config.getString(RestOptions.REST_ADDRESS); + int serverPort = config.getInteger(RestOptions.REST_PORT); + + RestClientConfiguration endpointConfiguration = RestClientConfiguration.fromConfiguration(config); --- End diff -- Maybe rename to `restClientConfiguration` > Create RESTful cluster endpoint > ------------------------------- > > Key: FLINK-7072 > URL: https://issues.apache.org/jira/browse/FLINK-7072 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination > Reporter: Till Rohrmann > Assignee: Chesnay Schepler > Labels: flip-6 > Fix For: 1.4.0 > > > In order to communicate with the cluster from the RESTful client, we have to > implement a RESTful cluster endpoint. The endpoint shall support the > following operations: > * List jobs (GET): Get list of all running jobs on the cluster > * Submit job (POST): Submit a job to the cluster (only supported in session > mode) > * Get job status (GET): Get the status of an executed job (and maybe the > JobExecutionResult) > * Lookup job leader (GET): Gets the JM leader for the given job > This endpoint will run in session mode alongside the dispatcher/session > runner and forward calls to this component which maintains a view on all > currently executed jobs. > In the per-job mode, the endpoint will return only the single running job and > the address of the JobManager alongside which it is running. Furthermore, it > won't accept job submissions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)