[
https://issues.apache.org/jira/browse/FLINK-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185921#comment-16185921
]
Malcolm Taylor commented on FLINK-7736:
---------------------------------------
Identified 14 alerts to address:
1) dereferenced variable is always null, in TaskSlotTable
2-3) array index out of bounds, in KVStateRequestSerializer and Utils
4) inconsistent equals and hashCode, in ArchivedJson
5-6) close input, in JarListHandler and SocketTextStreamFunction
7) close output, in JarFileCreator
8) unused format argument, in YarnApplicationMasterRunner
9) useless type test, in GroupReduceNode
10-11) useless comparison, in TaskExecutor and FieldAccessor
12-14) Result of integer multiplication cast to long, in MemoryManager and
twice in InPlaceMutableHashTable
> Fix some of the alerts raised by lgtm.com
> -----------------------------------------
>
> Key: FLINK-7736
> URL: https://issues.apache.org/jira/browse/FLINK-7736
> Project: Flink
> Issue Type: Improvement
> Reporter: Malcolm Taylor
> Assignee: Malcolm Taylor
>
> lgtm.com has identified a number of issues giving scope for improvement in
> the code: [https://lgtm.com/projects/g/apache/flink/alerts/?mode=list]
> This issue is to address some of the simpler ones. Some of these are quite
> clear bugs such as off-by-one errors. Others are areas where the code might
> be made clearer, such as use of a variable name which shadows another
> variable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
