[GitHub] flink pull request #4731: [FLINK-7700] Fix RocksDB state merging

[StefanRRichter]

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4731#discussion_r141340929
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ---
    @@ -1978,4 +1979,25 @@ public File getInstanceBasePath() {
        public boolean supportsAsynchronousSnapshots() {
                return true;
        }
    +
    +   @VisibleForTesting
    +   @SuppressWarnings("unchecked")
    +   @Override
    +   public int numStateEntries() {
    +           int count = 0;
    +
    +           for (Tuple2<ColumnFamilyHandle, 
RegisteredKeyedBackendStateMetaInfo<?, ?>> column : 
kvStateInformation.values()) {
    +                   RocksIterator rocksIterator = db.newIterator(column.f0);
    +                   rocksIterator.seekToFirst();
    +
    +                   while (rocksIterator.isValid()) {
    +                           count++;
    +                           rocksIterator.next();
    +                   }
    +                   rocksIterator.close();
    --- End diff --
    
    Could use try-with-resource here.


---