[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182421#comment-16182421
]
ASF GitHub Bot commented on FLINK-7668:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4728#discussion_r141318269
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -228,55 +245,55 @@ public WebRuntimeMonitor(
} else {
serverSSLContext = null;
}
- metricFetcher = new MetricFetcher(retriever,
queryServiceRetriever, executor, timeout);
+ metricFetcher = new MetricFetcher(retriever,
queryServiceRetriever, scheduledExecutor, timeout);
String defaultSavepointDir =
config.getString(CoreOptions.SAVEPOINT_DIRECTORY);
- JobCancellationWithSavepointHandlers cancelWithSavepoint = new
JobCancellationWithSavepointHandlers(currentGraphs, executor,
defaultSavepointDir);
+ JobCancellationWithSavepointHandlers cancelWithSavepoint = new
JobCancellationWithSavepointHandlers(executionGraphCache, scheduledExecutor,
defaultSavepointDir);
RuntimeMonitorHandler triggerHandler =
handler(cancelWithSavepoint.getTriggerHandler());
RuntimeMonitorHandler inProgressHandler =
handler(cancelWithSavepoint.getInProgressHandler());
Router router = new Router();
// config how to interact with this web server
- get(router, new DashboardConfigHandler(executor,
cfg.getRefreshInterval()));
+ get(router, new DashboardConfigHandler(scheduledExecutor,
cfg.getRefreshInterval()));
--- End diff --
But it's not necessarily about reducing the diff if the name change makes
it clearer what this object is.
> Add AccessExecutionGraph refresh interval to ExecutionGraphHolder
> -----------------------------------------------------------------
>
> Key: FLINK-7668
> URL: https://issues.apache.org/jira/browse/FLINK-7668
> Project: Flink
> Issue Type: Sub-task
> Components: REST
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> Once we support offline {{AccessExecutionGraph}} implementation (see
> FLINK-7667) we should add a refresh interval to the {{ExecutionGraphHolder}}
> after which the {{AccessExecutionGraph}} is retrieved again from the
> {{JobMaster}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
