Chesnay Schepler created FLINK-7692:
---------------------------------------

             Summary: Support user-defined variables
                 Key: FLINK-7692
                 URL: https://issues.apache.org/jira/browse/FLINK-7692
             Project: Flink
          Issue Type: Improvement
          Components: Metrics
    Affects Versions: 1.4.0
            Reporter: Chesnay Schepler
            Priority: Minor
             Fix For: 1.4.0


Reporters that identify metrics with a set of key-value pairs are currently 
limited to the variables defined by Flink, like the taskmanager ID, with users 
not being able to supply their own.

This is inconsistent with reporters that use metric identifiers that freely 
include user-defined groups constructted via {{MetricGroup#addGroup(String 
name)}}.

I propose adding a new method {{MetricGroup#addGroup(String key, String name)}} 
that adds a new key-value pair to the {{variables}} map in it's constructor. 
When constructing the metric identifier the key should be included as well, 
resulting in the same result as when constructing the metric groups tree via 
{{group.addGroup(key).addGroup(value)}}.

For this a new {{KeyedGenericMetricGroup}} should be created that resembles the 
unkeyed version, with slight modifications to the constructor and 
{{getScopeComponents}} method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to