[
https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178004#comment-16178004
]
ASF GitHub Bot commented on FLINK-7446:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/4710
[FLINK-7446] [table] Change DefinedRowtimeAttribute to work on existing
field.
## What is the purpose of the change
Changes the contract of the `DefinedRowtimeAttribute` interface. The
rowtime attribute is no longer appended to the schema of the row but marks an
existing field in the input that will be handled as event time attribute. The
specified field must be of type `Long` or `Timestamp`. The watermarks of
`DataStream` must be aligned to the specified field.
## Brief change log
- rowtime fields are no longer appended but an existing Long or Timestamp
field is marked as event time field
- Add checks that projections are not pushed to `TableSources` that
implement `DefinedRowtimeAttribute` or `DefinedProctimeAttribute`
- Added several tests for table sources with rowtime or proctime attributes
- Updated the documenation
## Verifying this change
- Check the added test cases
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
## Documentation
- Documentation is updated according to the changes of the PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink tableExistingField
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4710.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4710
----
commit 28f11bcf989e30d14b09b43891ee6012d77960aa
Author: Fabian Hueske <fhue...@apache.org>
Date: 2017-09-10T22:05:06Z
[FLINK-7446] [table] Change DefinedRowtimeAttribute to work on existing
field.
----
> Support to define an existing field as the rowtime field for TableSource
> ------------------------------------------------------------------------
>
> Key: FLINK-7446
> URL: https://issues.apache.org/jira/browse/FLINK-7446
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Fabian Hueske
>
> Currently {{DefinedRowtimeAttribute}} can define an appended rowtime field
> for a {{TableSource}}. But it would be helpful if we can support to define an
> existing field as the rowtime field. Just like registering a DataStream, the
> rowtime field can be appended but also can replace an existing field.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
