[
https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176444#comment-16176444
]
ASF GitHub Bot commented on FLINK-6444:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4705
[FLINK-6444] [build] Add a check that '@VisibleForTesting' methods ar…
## What is the purpose of the change
## Brief change log
## Verifying this change
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6444
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4705
----
commit 425c6eaee2d76df2df4f5d2070a33b1b4b9ddbcb
Author: zhangminglei <zml13856086...@163.com>
Date: 2017-09-22T13:44:18Z
[FLINK-6444] [build] Add a check that '@VisibleForTesting' methods are only
used in tests
----
> Add a check that '@VisibleForTesting' methods are only used in tests
> --------------------------------------------------------------------
>
> Key: FLINK-6444
> URL: https://issues.apache.org/jira/browse/FLINK-6444
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Stephan Ewen
> Assignee: Hai Zhou_UTC+8
>
> Some methods are annotated with {{@VisibleForTesting}}. These methods should
> only be called from tests.
> This is currently not enforced / checked during the build. We should add such
> a check.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
