Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4691#discussion_r140379775
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java
---
@@ -55,16 +59,19 @@
public class DispatcherRestEndpoint extends RestServerEndpoint {
private final GatewayRetriever<DispatcherGateway> leaderRetriever;
+ private final Configuration clusterConfiguration;
private final RestHandlerConfiguration restConfiguration;
private final Executor executor;
public DispatcherRestEndpoint(
- RestServerEndpointConfiguration configuration,
+ Configuration clusterConfiguration,
+ RestServerEndpointConfiguration endpointConfiguration,
--- End diff --
Shall we remove the order between `clusterConfiguration` and
`endpointConfiguration`? I usually like to have the super class arguments first.
---
