[ 
https://issues.apache.org/jira/browse/FLINK-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172883#comment-16172883
 ] 

ASF GitHub Bot commented on FLINK-7532:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4601#discussion_r139900700
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/files/WebContentHandlerSpecification.java
 ---
    @@ -0,0 +1,48 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler.legacy.files;
    +
    +import org.apache.flink.runtime.rest.HttpMethodWrapper;
    +import org.apache.flink.runtime.rest.handler.RestHandlerSpecification;
    +
    +/**
    + * Rest handler specification for the web content handler.
    + */
    +public final class WebContentHandlerSpecification implements 
RestHandlerSpecification {
    +
    +   private static final WebContentHandlerSpecification INSTANCE = new 
WebContentHandlerSpecification();
    +
    +   private WebContentHandlerSpecification() {
    +           throw new UnsupportedOperationException("Should not be called 
directly.");
    --- End diff --
    
    Good catch. Looking at it again, this must have been a brain fart ;-)


> Add StaticFileServerHandler to DispatcherRestEndpoint
> -----------------------------------------------------
>
>                 Key: FLINK-7532
>                 URL: https://issues.apache.org/jira/browse/FLINK-7532
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> The {{DispatcherRestEndpoint}} should be able to server static web content. 
> In order to do that it should instantiate the {{StaticFileServerHandler}} if 
> {{flink-runtime-web}} is in the classpath.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to