[ https://issues.apache.org/jira/browse/FLINK-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169885#comment-16169885 ]
ASF GitHub Bot commented on FLINK-7529: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4599#discussion_r139392946 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitorITCase.java --- @@ -479,41 +479,6 @@ public void testNoCopyFromJar() throws Exception { } } - private WebRuntimeMonitor startWebRuntimeMonitor( --- End diff -- This change belongs into the previous commit, i.e. `Create DispatcherRestEndpoint and integrate with Dispatcher`. > Retrieve complete REST address from RestfulGateway > -------------------------------------------------- > > Key: FLINK-7529 > URL: https://issues.apache.org/jira/browse/FLINK-7529 > Project: Flink > Issue Type: Improvement > Components: REST, Webfrontend > Affects Versions: 1.4.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Minor > Labels: flip-6 > > At the moment we only retrieve the web port from the > {{JobManager}}/{{Dispatcher}}. Instead it would be better to retrieve the > complete REST address from these components, including the protocol > (http/https) and the hostname. That way we wouldn't have to pass information > like wether https is enabled to all REST handlers where it is used for the > generation of the redirection address. -- This message was sent by Atlassian JIRA (v6.4.14#64029)