[
https://issues.apache.org/jira/browse/FLINK-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169221#comment-16169221
]
ASF GitHub Bot commented on FLINK-7630:
---------------------------------------
GitHub user tony810430 opened a pull request:
https://github.com/apache/flink/pull/4678
[FLINK-7630] Allow passing a File or an InputStream to
ParameterTool.fromPropertiesFile()
- Add two version with different parameter type for
`ParameterTool.fromPropertiesFile()` method
- Update unit test `ParameterToolTest.testFromPropertiesFile()`
- Update best practice document to introduce these two ways to use
`Parameter`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony810430/flink FLINK-7630
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4678
----
commit fa16ddd3e46112e0a96d6da6a1172e528aa1cb36
Author: Tony Wei <tony19920...@gmail.com>
Date: 2017-09-17T05:45:02Z
[FLINK-7630] Allow passing a File or an InputStream to
ParameterTool.fromPropertiesFile()
----
> Allow passing a File or an InputStream to ParameterTool.fromPropertiesFile()
> ----------------------------------------------------------------------------
>
> Key: FLINK-7630
> URL: https://issues.apache.org/jira/browse/FLINK-7630
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Wei-Che Wei
> Assignee: Wei-Che Wei
>
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/How-to-user-ParameterTool-fromPropertiesFile-to-get-resource-file-inside-my-jar-tp15482.html
> From this discussion, it seems that the current functionality of
> {{ParameterTool.fromPropertiesFile}} is not enough.
> It will be more useful if {{ParameterTool.fromPropertiesFile}} can provide
> more kinds of parameter type such as {{File}} and {{InputStream}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
