[ https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165836#comment-16165836 ]
ASF GitHub Bot commented on FLINK-7617: --------------------------------------- Github user JingsongLi commented on the issue: https://github.com/apache/flink/pull/4668 ## Performance - HashVsSortMiniBenchmark: use buildSideOuterJoin testBuildFirst: 16s 208ms(before) 10s 98ms(after) testBuildSecond: 7s 793ms(before) 6s 67ms(after) R: @KurtYoung > Remove string format in BitSet to improve the performance of > BuildSideOuterjoin > ------------------------------------------------------------------------------- > > Key: FLINK-7617 > URL: https://issues.apache.org/jira/browse/FLINK-7617 > Project: Flink > Issue Type: Improvement > Components: Local Runtime > Reporter: Jingsong Lee > > When using BuildSideOuterjoin, will frequently call Bitset.set and get, there > will be > Preconditions.checkArgument (index <bitLength && index> = 0, > String.format ("Input Index [% d] is larger than BitSet available size [% > d].", Index, bitLength)); > Of the check, String.format will lead to a sharp decline performance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)