Github user ggevay commented on the issue:

    https://github.com/apache/flink/pull/3511
  
    I'm not exactly sure how to do `FixedLengthRecordSorter`.
    @greghogan , could you please clarify what you meant in the following?
    
    > Rather than extending NormalizedKeySorter, we could pull the compare and 
swap functions out of
    > MemorySegment into an interface with a default implementation moved from 
NormalizedKeySorter
    > and FixedLengthRecordSorter. There is overlap in that the 
normalizedKeyFullyDetermines case of 
    > NormalizedKeySorter results in the same operations as in 
FixedLengthRecordSorter.
    
    Do you mean that the generated code would implement this interface? What 
would be the relation between the non-generated `NormalizedKeySorter` class and 
this interface? Would this change introduce more virtual calls?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to