[ 
https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143416#comment-16143416
 ] 

ASF GitHub Bot commented on FLINK-7378:
---------------------------------------

Github user zhijiangW commented on the issue:

    https://github.com/apache/flink/pull/4485
  
    @NicoK , thank you for giving this discussion and comments!
    
    Actually I proposed the same way of using fixed-size `LocalBufferPool` for 
managing exclusive buffers for per `RemoteInputChannel` with stephan before 
implementation. I attached the dialogue below:
    
![dingtalk20170828140949](https://user-images.githubusercontent.com/12387855/29761347-767c7c84-8bfb-11e7-975b-706265766803.png)
    
    Maybe I did not catch stephan's meaning from the above dialogue and took 
the current way to implement.  I also agree with the way you mentioned and the 
fixed-size buffer pool for `RemoteInputChannel` can be submitted in an separate 
PR.



> Create a fix size (non rebalancing) buffer pool type for the floating buffers
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-7378
>                 URL: https://issues.apache.org/jira/browse/FLINK-7378
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.4.0
>
>
> Currently the number of network buffers in {{LocalBufferPool}} for 
> {{SingleInputGate}} is limited by {{a * <number of channels> + b}}, where a 
> is the number of exclusive buffers for each channel and b is the number of 
> floating buffers shared by all channels.
> Considering the credit-based flow control feature, we want to create a fix 
> size buffer pool used to manage the floating buffers for {{SingleInputGate}}. 
> And the exclusive buffers are assigned to {{InputChannel}}s directly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to