GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4592
[FLINK-7515][network] allow actual 0-length content in
NettyMessage#allocateBuffer()
## What is the purpose of the change
Previously, length "0" meant "unknown content length" but there are cases
where the actual length is "0" and we do not need a larger buffer than the
header size.
## Brief change log
- use -1 for tagging the special case of an unknown content length
- change buffers with 0-size content to start with the header size only
## Verifying this change
This change is already covered by existing tests, such as
`NettyMessageSerializationTest` and many more network-related tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7515
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4592.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4592
----
commit 828548d6e4b2390fc607f55382aa1af2ffa5095f
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-08-24T15:14:38Z
[FLINK-7515][network] allow actual 0-length content in
NettyMessage#allocateBuffer()
Previously, length "0" meant "unknown content length" but there are cases
where
the actual length is 0 and so we use -1 for tagging the special case now.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
