[
https://issues.apache.org/jira/browse/FLINK-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141543#comment-16141543
]
ASF GitHub Bot commented on FLINK-7513:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4590
[FLINK-7513][tests] remove TestBufferFactory#MOCK_BUFFER
## What is the purpose of the change
The static `TestBufferFactory#MOCK_BUFFER` buffer did not allow proper
reference counting and we should rather create test buffers in the tests which
may also be released afterwards.
## Brief change log
- replace `TestBufferFactory#MOCK_BUFFER` use with
`TestBufferFactory.createBuffer()`
- fix this buffer's reference counting and make sure it is correct
## Verifying this change
This change is already covered by existing tests, such as
`RemoteInputChannelTest` which was the only user of
`TestBufferFactory#MOCK_BUFFER`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7513
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4590.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4590
----
commit 511d0b7893c83b94d151f9546165de7d1ce979b4
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-08-24T14:49:46Z
[FLINK-7513][tests] remove TestBufferFactory#MOCK_BUFFER
This static buffer did not allow proper reference counting and we should
rather
create test buffers in the tests which may also be released afterwards.
----
> remove TestBufferFactory#MOCK_BUFFER
> ------------------------------------
>
> Key: FLINK-7513
> URL: https://issues.apache.org/jira/browse/FLINK-7513
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> {{TestBufferFactory#MOCK_BUFFER}} is a static buffer in tests and did not
> allow proper reference counting and we should rather create test buffers in
> the tests which may also be released afterwards.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
