Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r135124134
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -759,10 +786,12 @@ object AggregateUtil {
: GroupCombineFunction[Row, Row] = {
val needRetract = false
- val (aggFieldIndexes, aggregates, accTypes) =
transformToAggregateFunctions(
+ val isStateBackedDataViews = false
+ val (aggFieldIndexes, aggregates, accTypes, accSpecs) =
transformToAggregateFunctions(
--- End diff --
`transformToAggregateFunctions` has a default value for
`isStateBackedDataViews`. So we don't need to pass a parameter. Moreover, we
only need to pass data view information to the code generator if the data views
are backed by state (if we make it an optional parameter). So most of the
changes here can be reverted (and also for all other operators that do not
support state backed views).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
