GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4581
[FLINK-7499][io] also let AsynchronousBufferFileWriter#writeBlock() recycle
the buffer in case of failures
## What is the purpose of the change
`SpillableSubpartitionView#releaseMemory()` recycled the given buffer
twice: once asynchronously after the write operation initiated via
`AsynchronousBufferFileWriter#writeBlock()`and once in
SpillableSubpartitionView#releaseMemory() after adding the write operation to
the queue. Additionally, other uses of
`AsynchronousBufferFileWriter#writeBlock()` did not cleanup in an error case
which was also not done by `AsynchronousBufferFileWriter#writeBlock()` itself.
This PR changes the behaviour of
`AsynchronousBufferFileWriter#writeBlock()` to always take care of releasing
the buffer, even adding the (asynchronous) write operation failed.
## Brief change log
- let `AsynchronousBufferFileWriter#writeBlock()` take full recycling
responsibility of the given buffer even in case of failures
- remove the additional `recycle` call in
`SpillableSubpartitionView#releaseMemory()`
- adapt `SpillableSubpartitionTest` to find the duplicate `recycle()` calls
## Verifying this change
This change added further checks to `SpillableSubpartitionTest` to verify
the intended behaviour
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4581
----
commit a986ebac2da4ac4ad00717e834fdc33f9fe9eb3a
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-08-24T10:17:08Z
[FLINK-7499][io] also let AsynchronousBufferFileWriter#writeBlock() recycle
the buffer in case of failures
This fixes a double-recycle in SpillableSubpartitionView and also makes sure
that even if adding the (asynchronous) write operation fails, the buffer is
properly freed in code that did not perform this cleanup. It avoids code
duplication of this cleanup and it is also more consistent to take over
responsibility of the given buffer even if an exception is thrown.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
