Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4569#discussion_r134471228
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClientEndpoint.java
---
@@ -155,38 +129,66 @@ public void shutdown() {
.set(HttpHeaders.Names.HOST, configuredTargetAddress +
":" + configuredTargetPort)
.set(HttpHeaders.Names.CONNECTION,
HttpHeaders.Values.CLOSE);
- synchronized (this) {
- // This ensures strict sequential processing of
requests.
- // If we send new requests immediately we can no longer
make assumptions about the order in which responses
- // arrive, due to which the handler cannot know which
future he should complete (not to mention what response
- // type to read).
- CompletableFuture<P> nextFuture = lastFuture
- .handleAsync((f, e) ->
submitRequest(httpRequest, messageHeaders), directExecutor)
- .thenCompose((future) -> future);
-
- lastFuture = nextFuture;
- return nextFuture;
- }
+ return submitRequest(httpRequest, messageHeaders);
}
private <M extends MessageHeaders<R, P, U>, U extends ParameterMapper,
R extends RequestBody, P extends ResponseBody> CompletableFuture<P>
submitRequest(FullHttpRequest httpRequest, M messageHeaders) {
- CompletableFuture<P> responseFuture =
handler.expectResponse(messageHeaders.getResponseClass());
-
- try {
- // write request
- Channel channel =
bootstrap.connect(configuredTargetAddress,
configuredTargetPort).sync().channel();
- channel.writeAndFlush(httpRequest);
- channel.closeFuture();
- } catch (InterruptedException e) {
- return FutureUtils.completedExceptionally(e);
+ synchronized (lock) {
+ CompletableFuture<P> responseFuture =
ClientHandler.addHandlerForResponse(bootstrap, sslEngine,
messageHeaders.getResponseClass());
+
+ try {
+ // write request
+ Channel channel =
bootstrap.connect(configuredTargetAddress,
configuredTargetPort).sync().channel();
--- End diff --
Can we do the `sync` in a future, then it's not blocking?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
