Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4562#discussion_r134166175
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
 ---
    @@ -220,6 +220,10 @@ void releaseBuffer() {
     
                @Override
                ByteBuf write(ByteBufAllocator allocator) throws IOException {
    +                   if (null == buffer) {
    +                           throw new NullPointerException();
    --- End diff --
    
    actually, better use `Preconditions#checkNotNull(T)` - an additional error 
message there usually does not make too much sense as the failure is clear


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to