[
https://issues.apache.org/jira/browse/FLINK-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130190#comment-16130190
]
ASF GitHub Bot commented on FLINK-7057:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4558
[FLINK-7057][tests][hotfix] make sure the client and a created InputStream
are closed
## What is the purpose of the change
This fixes some stalling tests in the following cases: if the client is not
closed and the inputstream of a GET operation was not fully read and the server
has not yet sent all data packets, it may still hold the read lock and block
any writing operations (also see FLINK-7467). As a result, a user reported
`BlobServerDeleteTest#testDeleteSingleByBlobKey()` to hang.
## Brief change log
- (fully read and) close all `InputStream` instances returned by
`BlobClient#get()`
- add missing `close` calls to `BlobClient` uses in the tests
## Verifying this change
This change is affects and fixes existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-6916-7057-hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4558.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4558
----
commit f80025773b071a67fdcbe612d58ee16ee7cbbc52
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-08-17T10:04:09Z
[FLINK-7057][tests][hotfix] make sure the client and a created InputStream
are closed
If not and the server has not yet sent all data packets, it may still
occupy the
read lock and block any writing operations (also see FLINK-7467).
----
> move BLOB ref-counting from LibraryCacheManager to BlobCache
> ------------------------------------------------------------
>
> Key: FLINK-7057
> URL: https://issues.apache.org/jira/browse/FLINK-7057
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> Currently, the {{LibraryCacheManager}} is doing some ref-counting for JAR
> files managed by it. Instead, we want the {{BlobCache}} to do that itself for
> all job-related BLOBs. Also, we do not want to operate on a per-{{BlobKey}}
> level but rather per job. Therefore, the cleanup process should be adapted,
> too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
