[ 
https://issues.apache.org/jira/browse/FLINK-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125491#comment-16125491
 ] 

ASF GitHub Bot commented on FLINK-7419:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4524#discussion_r132914215
  
    --- Diff: flink-connectors/flink-avro/pom.xml ---
    @@ -174,6 +174,35 @@ under the License.
                                        </execution>
                                </executions>
                        </plugin>
    +
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-shade-plugin</artifactId>
    +                           <executions>
    +                                   <execution>
    +                                           <id>shade-flink</id>
    +                                           <phase>package</phase>
    +                                           <goals>
    +                                                   <goal>shade</goal>
    +                                           </goals>
    +                                           <configuration 
combine.self="override">
    +                                                   
<dependencyReducedPomLocation>${project.basedir}/target/dependency-reduced-pom.xml</dependencyReducedPomLocation>
    +                                                   
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
    +                                                   <artifactSet>
    +                                                           <includes>
    +                                                                   
<include>org.codehaus.jackson:*</include>
    +                                                           </includes>
    +                                                   </artifactSet>
    +                                                   <relocations>
    +                                                           <relocation>
    +                                                                   
<pattern>org.codehaus.jackson</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.avro.org.codehouse.jackson</shadedPattern>
    --- End diff --
    
    Please switch the pattern to `... avro.shaded....` . I would like to 
reserver the `org.apache.flink.shaded` namespaces for dependencies from 
flink-shaded.


> Shade jackson dependency in flink-avro
> --------------------------------------
>
>                 Key: FLINK-7419
>                 URL: https://issues.apache.org/jira/browse/FLINK-7419
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: Fang Yong
>             Fix For: 1.4.0
>
>
> Avro uses {{org.codehouse.jackson}} which also exists in multiple 
> incompatible versions. We should shade it to 
> {{org.apache.flink.shaded.avro.org.codehouse.jackson}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to