Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4473#discussion_r132879203
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -115,13 +116,13 @@ public String getTargetStream(OUT element) {
* This is a constructor supporting {@see KinesisSerializationSchema}.
*
* @param schema Kinesis serialization schema for the data type
- * @param configProps The properties used to configure AWS credentials
and AWS region
+ * @param configProps The properties used to configure KinesisProducer,
including AWS credentials and AWS region
*/
public FlinkKinesisProducer(KinesisSerializationSchema<OUT> schema,
Properties configProps) {
- this.configProps = checkNotNull(configProps, "configProps can
not be null");
-
- // check the configuration properties for any conflicting
settings
-
KinesisConfigUtil.validateProducerConfiguration(this.configProps);
+ checkNotNull(configProps, "configProps can not be null");
+ this.configProps =
KinesisConfigUtil.replaceDeprecatedProducerKeys(configProps);
+ // check the configuration properties for any invalid settings
+ this.producerConfig =
KinesisConfigUtil.validateProducerConfiguration(configProps);
--- End diff --
For non-serializable fields that needs to be `transient`, we should only
initialize them in `open`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
