Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4485#discussion_r132673916
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
 ---
    @@ -221,13 +228,44 @@ public BufferPool createBufferPool(int 
numRequiredBuffers, int maxUsedBuffers) t
        }
     
        @Override
    +   public BufferPool createFixedBufferPool(int numRequiredBuffers) throws 
IOException {
    +           synchronized (factoryLock) {
    +                   if (isDestroyed) {
    +                           throw new IllegalStateException("Network buffer 
pool has already been destroyed.");
    +                   }
    +
    +                   // Ensure that the number of required buffers can be 
satisfied.
    +                   if (numTotalRequiredBuffers + numRequiredBuffers > 
totalNumberOfMemorySegments) {
    +                           throw new 
IOException(String.format("Insufficient number of network buffers: " +
    --- End diff --
    
    why not keep the whole message as in `#createBufferPool`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to