GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4529
[FLINK-7428][network] avoid buffer copies when receiving messages
## What is the purpose of the change
The `LengthFieldBasedFrameDecoder` used so far creates one additional copy
in its `#extractFrame()` method which is avoidable in our use case and changed
by this PR (based upon #4528).
## Brief change log
- let `NettyMessageDecoder` inherit from `LengthFieldBasedFrameDecoder`
(instead of being an additional step in the pipeline)
- override `LengthFieldBasedFrameDecoder#extractFrame()` similarly to the
`ObjectDecoder` class provided by netty itself
## Verifying this change
This change is already covered by existing tests, such as
NettyMessageSerializationTest as well as many other tests involving network
communication, e.g. IT cases.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (yes: network "deserialisation")
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes: network communication)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7428
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4529.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4529
----
commit 1c0e5aae05f3e4eaec986792b508a08ee242ac73
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-08-10T14:58:19Z
[FLINK-7427][network] integrate PartitionRequestProtocol into NettyProtocol
- removes one level of (unneeded) abstraction for clarity
commit 18c665a2bec35b98da165f243b64faaf4d6ea056
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-08-10T16:23:18Z
[FLINK-7428][network] avoid buffer copies when receiving messages
The LengthFieldBasedFrameDecoder used so far creates one additional copy in
its
`#extractFrame()` method which is avoidable in our case. We do so by letting
`NettyMessageDecoder` inherit from it (instead of being an additional step
in
the pipeline) and overriding this similarly to the `ObjectDecoder` class
provided by netty itself.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
