[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121590#comment-16121590 ]
ASF GitHub Bot commented on FLINK-6244: --------------------------------------- Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r132443663 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -82,36 +78,54 @@ class PatternStream[T](jPatternStream: JPatternStream[T]) { * pattern sequence. * @tparam L Type of the resulting timeout event * @tparam R Type of the resulting event + * @deprecated Use the version that returns timeouted events as a side-output * @return Data stream of either type which contains the resulting events and resulting timeout * events. */ + @deprecated def select[L: TypeInformation, R: TypeInformation]( patternTimeoutFunction: PatternTimeoutFunction[T, L], patternSelectFunction: PatternSelectFunction[T, R]) : DataStream[Either[L, R]] = { + val outputTag = OutputTag[L]("dummy-timeouted") --- End diff -- Maybe don't use "dummy" for that. > Emit timeouted Patterns as Side Output > -------------------------------------- > > Key: FLINK-6244 > URL: https://issues.apache.org/jira/browse/FLINK-6244 > Project: Flink > Issue Type: Improvement > Components: CEP > Affects Versions: 1.3.0 > Reporter: Dawid Wysakowicz > Assignee: Dawid Wysakowicz > Fix For: 1.4.0 > > > Now that we have SideOuputs I think timeouted patterns should be emitted into > them rather than producing a stream of `Either` -- This message was sent by Atlassian JIRA (v6.4.14#64029)