[ https://issues.apache.org/jira/browse/FLINK-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119982#comment-16119982 ]
ASF GitHub Bot commented on FLINK-7381: --------------------------------------- Github user zentol commented on the issue: https://github.com/apache/flink/pull/4492 Thanks for testing things on yarn/HA. As for the web monitor options, I do see the point of not coupling new options to the jobmanager. However, I think it's a bad idea to have some be tied to the jobmanager while others aren't. This smells like a repeat of the ConfigOption introduction, where we approached things with a "let's refactor the rest later" mentality, and that still isn't complete. I suggest to port all webmonitor options first (with deprecates keys obviously), and then rebase the PR on top of that. > Decouple WebRuntimeMonitor from ActorGateway > -------------------------------------------- > > Key: FLINK-7381 > URL: https://issues.apache.org/jira/browse/FLINK-7381 > Project: Flink > Issue Type: Sub-task > Components: Webfrontend > Affects Versions: 1.4.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > > The {{WebRuntimeMonitor}} has a hard wired dependency on the {{ActorGateway}} > in order to communicate with the {{JobManager}}. In order to make it work > with the {{JobMaster}} (Flip-6), we have to abstract this dependency away. I > propose to add a {{JobManagerGateway}} interface which can be implemented > using Akka for the old {{JobManager}} code. The Flip-6 {{JobMasterGateway}} > can then directly inherit from this interface. -- This message was sent by Atlassian JIRA (v6.4.14#64029)