Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4234#discussion_r131431720
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheSuccessTest.java
---
@@ -92,15 +100,15 @@ private void uploadFileGetTest(final Configuration
config, boolean cacheWorksWit
BlobCache blobCache = null;
BlobStoreService blobStoreService = null;
try {
- final Configuration cacheConfig;
- if (cacheHasAccessToFs) {
- cacheConfig = config;
- } else {
- // just in case parameters are still read from
the server,
- // create a separate configuration object for
the cache
- cacheConfig = new Configuration(config);
+ final Configuration cacheConfig = new
Configuration(config);
+
cacheConfig.setString(BlobServerOptions.STORAGE_DIRECTORY,
+ temporaryFolder.newFolder().getAbsolutePath());
+ if (!cacheHasAccessToFs) {
+ // make sure the cache cannot access the HA
store directly
+
cacheConfig.setString(BlobServerOptions.STORAGE_DIRECTORY,
+
temporaryFolder.newFolder().getAbsolutePath());
--- End diff --
seems that it wasn't used to its full extension - also the meaning of this
variable was not what clear
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
