[ 
https://issues.apache.org/jira/browse/FLINK-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107239#comment-16107239
 ] 

ASF GitHub Bot commented on FLINK-7185:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4340#discussion_r130338928
  
    --- Diff: 
flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
    @@ -23,9 +23,32 @@
     import org.apache.flink.api.java.ExecutionEnvironment;
     import org.apache.flink.api.java.Utils;
     import org.apache.flink.api.java.operators.DataSource;
    -//CHECKSTYLE.OFF: AvoidStarImport - Needed for TupleGenerator
    -import org.apache.flink.api.java.tuple.*;
    -//CHECKSTYLE.ON: AvoidStarImport
    +import org.apache.flink.api.java.tuple.Tuple;
    +import org.apache.flink.api.java.tuple.Tuple1;
    +import org.apache.flink.api.java.tuple.Tuple10;
    +import org.apache.flink.api.java.tuple.Tuple11;
    +import org.apache.flink.api.java.tuple.Tuple12;
    +import org.apache.flink.api.java.tuple.Tuple13;
    +import org.apache.flink.api.java.tuple.Tuple14;
    +import org.apache.flink.api.java.tuple.Tuple15;
    +import org.apache.flink.api.java.tuple.Tuple16;
    +import org.apache.flink.api.java.tuple.Tuple17;
    +import org.apache.flink.api.java.tuple.Tuple18;
    +import org.apache.flink.api.java.tuple.Tuple19;
    --- End diff --
    
    We will have to disable them in place as we otherwise disable entire rules 
for some files. You can specify multiple rules to disable like this: 
`//CHECKSTYLE.OFF: AvoidStarImport|ImportOrder`. At least that should work.


> Activate checkstyle flink-java/io
> ---------------------------------
>
>                 Key: FLINK-7185
>                 URL: https://issues.apache.org/jira/browse/FLINK-7185
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to