[ https://issues.apache.org/jira/browse/FLINK-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107228#comment-16107228 ]
ASF GitHub Bot commented on FLINK-7304: --------------------------------------- GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4427 [FLINK-7304] [scripts] Simplify taskmanager GC configuration ## What is the purpose of the change Simplify jdk-version-dependent GC configuration in `taskmanager.sh` since we only use jdk8. ## Verifying this change Run `taskmanager.sh` and check JVM options. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) ## Documentation - Does this pull request introduce a new feature? (~~yes~~ / no) - If yes, how is the feature documented? (not applicable~~ / docs / JavaDocs / not documented~~) You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 7304 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4427.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4427 ---- commit 31f218773c3ee8b0a24aa84bfea37633b063f335 Author: zentol <ches...@apache.org> Date: 2017-07-31T10:18:07Z [FLINK-7304] [scripts] Simplify taskmanager GC configuration ---- > Simnplify garbage collector configuration in taskmanager.sh > ----------------------------------------------------------- > > Key: FLINK-7304 > URL: https://issues.apache.org/jira/browse/FLINK-7304 > Project: Flink > Issue Type: Sub-task > Components: Startup Shell Scripts > Affects Versions: 1.4.0 > Reporter: Chesnay Schepler > Assignee: Chesnay Schepler > Fix For: 1.4.0 > > > The {{taskmanager.sh}} has separate garbage collector configurations for java > 7 and 8. Now that we drop support for java 7 we can simplify this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)