GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4417
[hotfix][tests] fix Invokable subclasses being private
## What is the purpose of the change
Recently, some `Invokable` subclasses became `private` and thus failed to
be executed at the task managers. This fixes the problem in one `@Ignore`d
class (which was not working anymore) and one where the result of the job
execution did not matter and only produces an superfluous log entry.
## Brief change log
- fix `JobRetrievalITCase#testJobRetrieval()` test job not running
- fix `NetworkStackThroughputITCase` not working anymore
## Verifying this change
This change is already covered by existing tests, such as
`JobRetrievalITCase` (where the error only showed as a superfluous exception in
the logs) and `NetworkStackThroughputITCase` (which was not working anymore but
is a manual test).
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink hotfix_private_invokables
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4417.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4417
----
commit b2cd6e128912c54fcbbaf451ff79394a32beb39a
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-07-28T12:16:10Z
[hotfix][tests] fix JobRetrievalITCase#testJobRetrieval() test job not
running
Although this test should only verify that ClusterClient#retrieveJob() is
working, the inability to run the invokable given to the job does at least
print
an exception in the test output that may be confusing.
commit 287d235521b37dee58b95b5ede3753b2b2189aa4
Author: Nico Kruber <n...@data-artisans.com>
Date: 2017-07-28T12:18:09Z
[hotfix][tests] fix NetworkStackThroughputITCase not working anymore
Invokable classes need to stay public in order to be successfully executed
by
the TM.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
