GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4409

    [FLINK-7283][python] fix PythonPlanBinderTest issues with python paths

    ## What is the purpose of the change
    
    Fix Python 2/3 path issues in `PythonPlanBinderTest`.
    
    ## Brief change log
    
    in `PythonPlanBinderTest`:
      - the path is now set correctly in the `configuration`variable, not in 
the `config` member
      - for Python 2, try `python2` and `python` and verify that it is actually 
referring to Python 2
      - same for Python 3
    
    ## Verifying this change
    
    This change fixes an actual unit test and extends its range on various 
systems.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7283

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4409
    
----
commit a5e63645060b4e00bfb0caebfc6c387e90b871e2
Author: Nico Kruber <n...@data-artisans.com>
Date:   2017-07-27T14:35:37Z

    [FLINK-7283][python] fix PythonPlanBinderTest issues with python paths
    
    * the path is not set correctly (only inside config, not the configuration 
that
      is passed on to the PythonPlanBinder
    * linux distributions have become quite inventive regarding python binary 
names:
      some offer python as Python 2, some as Python 3. Similarly, python3 and/or
      python2 may not be available. If we really want to test both, we need to 
take
      this into account.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to