[
https://issues.apache.org/jira/browse/FLINK-7065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101813#comment-16101813
]
ASF GitHub Bot commented on FLINK-7065:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4273#discussion_r129598422
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/RemoteExecutor.java ---
@@ -106,8 +113,14 @@ public RemoteExecutor(InetSocketAddress inet,
Configuration clientConfiguration,
List<URL> jarFiles, List<URL> globalClasspaths) {
this.clientConfiguration = clientConfiguration;
this.jarFiles = jarFiles;
+ for (URL jarFileUrl : jarFiles) {
+ try {
+ JobWithJars.checkJarFile(jarFileUrl);
+ } catch (IOException e) {
+ throw new RuntimeException("Problem with jar
file " + jarFileUrl, e);
--- End diff --
Can we make this a checked exception?
> separate the flink-streaming-java module from flink-clients
> ------------------------------------------------------------
>
> Key: FLINK-7065
> URL: https://issues.apache.org/jira/browse/FLINK-7065
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Xu Pingyong
> Assignee: Xu Pingyong
>
> Motivation:
> It is not good that "flink-streaming-java" module depends on
> "flink-clients". Flink-clients should see something in "flink-streaming-java".
> Related Change:
> 1. LocalStreamEnvironment and RemoteStreamEnvironment can also execute
> a job by the executors(LocalExecutor and RemoteExecutor). Introduce
> StreamGraphExecutor which executors a streamGraph as PlanExecutor executors
> the plan. StreamGraphExecutor and PlanExecutor all extend Executor.
> 2. Introduce StreamExecutionEnvironmentFactory which works similarly
> to ContextEnvironmentFactory in flink-clients.
> When a object of ContextEnvironmentFactory,
> OptimizerPlanEnvironmentFactory or PreviewPlanEnvironmentFactory is set into
> ExecutionEnvironment(by calling initializeContextEnvironment)， the relevant
> StreamEnvFactory is alsot set into StreamExecutionEnvironment. It is similar
> when calling unsetContext.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
