[ https://issues.apache.org/jira/browse/FLINK-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094892#comment-16094892 ]
ASF GitHub Bot commented on FLINK-7174: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4321 This patch looks good. As a minor comment: I would prefer to not have `hasAssignedPartitions` as a field, but rather return it from the `reassignPartitions()` method and have it only as a local variable in the `run()` method. > Bump dependency of Kafka 0.10.x to the latest one > ------------------------------------------------- > > Key: FLINK-7174 > URL: https://issues.apache.org/jira/browse/FLINK-7174 > Project: Flink > Issue Type: Improvement > Components: Kafka Connector > Reporter: Piotr Nowojski > Assignee: Piotr Nowojski > > We are using pretty old Kafka version for 0.10. Besides any bug fixes and > improvements that were made between 0.10.0.1 and 0.10.2.1, it 0.10.2.1 > version is more similar to 0.11.0. -- This message was sent by Atlassian JIRA (v6.4.14#64029)