Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4321#discussion_r128180555
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -335,6 +356,9 @@ public void setOffsetsToCommit(Map<TopicPartition,
OffsetAndMetadata> offsetsToC
*/
@VisibleForTesting
void reassignPartitions(List<KafkaTopicPartitionState<TopicPartition>>
newPartitions) throws Exception {
+ if (newPartitions.size() > 0) {
+ hasAssignedPartitions = true;
+ }
--- End diff --
Should we actually extend this `if` block to wrap the whole code in
`reassignPartitions`? I.e., we shouldn't be doing the reassignment logic if
`newPartitions.size() == 0`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
