[ 
https://issues.apache.org/jira/browse/FLINK-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574207#comment-14574207
 ] 

ASF GitHub Bot commented on FLINK-2139:
---------------------------------------

Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/789#issuecomment-109218281
  
    Both are good points. 
    
    As for the socket test I can do one of the following:
       * Do not test it
       * Test it with smaller data
       * Mock the socket with some collection
    
    I am not not really happy with any of these options to be honest, but maybe 
I am just missing something.
    
    As for the ITCases, you are right, I have to admit that I was looking at 
the 
[AvroOutputFormatTest](https://github.com/apache/flink/blob/master/flink-staging/flink-avro/src/test/java/org/apache/flink/api/avro/AvroOutputFormatTest.java)
 and named my tests accordingly. So you would suggest renaming that too then?


> Test Streaming Outputformats
> ----------------------------
>
>                 Key: FLINK-2139
>                 URL: https://issues.apache.org/jira/browse/FLINK-2139
>             Project: Flink
>          Issue Type: Test
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Márton Balassi
>            Assignee: Márton Balassi
>             Fix For: 0.9
>
>
> Currently the only tested streaming core output is the writeAsTest and that 
> is only tested indirectly in integration tests. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to