Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4266#discussion_r126680468 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/WindowJoinUtil.scala --- @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.table.runtime.join + +import java.math.{BigDecimal => JBigDecimal} +import java.util + +import org.apache.calcite.plan.RelOptUtil +import org.apache.calcite.rel.`type`.RelDataType +import org.apache.calcite.rel.core.JoinRelType +import org.apache.calcite.rex._ +import org.apache.calcite.sql.SqlKind +import org.apache.flink.api.common.functions.FlatJoinFunction +import org.apache.flink.api.common.typeinfo.TypeInformation +import org.apache.flink.table.api.{TableConfig, TableException} +import org.apache.flink.table.calcite.FlinkTypeFactory +import org.apache.flink.table.codegen.{CodeGenerator, ExpressionReducer} +import org.apache.flink.table.plan.schema.{RowSchema, TimeIndicatorRelDataType} +import org.apache.flink.types.Row + +import scala.collection.JavaConverters._ + +/** + * An util class to help analyze and build join code . + */ +object WindowJoinUtil { + + /** + * Analyze time-condtion to get time boundary for each stream and get the time type + * and return remain condition. + * + * @param condition join condition + * @param leftLogicalFieldCnt left stream logical field num + * @param inputSchema join rowtype schema + * @param rexBuilder util to build rexNode + * @param config table environment config + * @return isRowTime, left lower boundary, right lower boundary, remain condition + */ + private[flink] def analyzeTimeBoundary( + condition: RexNode, + leftLogicalFieldCnt: Int, + inputSchema: RowSchema, + rexBuilder: RexBuilder, + config: TableConfig): (Boolean, Long, Long, Option[RexNode]) = { + + // Converts the condition to conjunctive normal form (CNF) + val cnfCondition = RexUtil.toCnf(rexBuilder, condition) + + // split the condition into time indicator condition and other condition + val (timeTerms, remainTerms) = cnfCondition match { + case c: RexCall if cnfCondition.getKind == SqlKind.AND => + c.getOperands.asScala + .map(analyzeCondtionTermType(_, leftLogicalFieldCnt, inputSchema.logicalType)) + .reduceLeft((l, r) => { + (l._1 ++ r._1, l._2 ++ r._2) + }) + case _ => + throw new TableException("A time-based stream join requires exactly " + + "two join predicates that bound the time in both directions.") + } + + if (timeTerms.size != 2) { + throw new TableException("A time-based stream join requires exactly " + + "two join predicates that bound the time in both directions.") + } + + // extract time offset from the time indicator conditon --- End diff -- minor typo: conditon -> condition
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---