[ 
https://issues.apache.org/jira/browse/FLINK-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085159#comment-16085159
 ] 

mingleizhang commented on FLINK-5541:
-------------------------------------

Thanks Ted report this, I wil take a look.

> Missing null check for localJar in FlinkSubmitter#submitTopology()
> ------------------------------------------------------------------
>
>                 Key: FLINK-5541
>                 URL: https://issues.apache.org/jira/browse/FLINK-5541
>             Project: Flink
>          Issue Type: Bug
>          Components: Storm Compatibility
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>       if (localJar == null) {
>         try {
>           for (final URL url : ((ContextEnvironment) 
> ExecutionEnvironment.getExecutionEnvironment())
>               .getJars()) {
>             // TODO verify that there is only one jar
>             localJar = new File(url.toURI()).getAbsolutePath();
>           }
>         } catch (final URISyntaxException e) {
>           // ignore
>         } catch (final ClassCastException e) {
>           // ignore
>         }
>       }
>       logger.info("Submitting topology " + name + " in distributed mode with 
> conf " + serConf);
>       client.submitTopologyWithOpts(name, localJar, topology);
> {code}
> Since the try block may encounter URISyntaxException / ClassCastException, we 
> should check that localJar is not null before calling 
> submitTopologyWithOpts().



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to