[ 
https://issues.apache.org/jira/browse/FLINK-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080363#comment-16080363
 ] 

ASF GitHub Bot commented on FLINK-6940:
---------------------------------------

Github user alpinegizmo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4136#discussion_r126431179
  
    --- Diff: docs/ops/state_backends.md ---
    @@ -123,8 +123,7 @@ RocksDBStateBackend is currently the only backend that 
offers incremental checkp
     
     ## Configuring a State Backend
     
    -State backends can be configured per job. In addition, you can define a 
default state backend to be used when the
    -job does not explicitly define a state backend.
    +State backends can be configured per job in code. In addition, you can 
define a default state backend in **flink-conf.yaml** that is used when the job 
does not explicitly define a state backend.
    --- End diff --
    
    @zentol I find that "in code" reads rather awkwardly, and I don't see how 
it adds any value, since the details of how to do per-job configuration are 
shown below. Nevertheless, this topic can be a bit confusing, so I would 
suggest something more like this (assuming I got the details right):
    
    The default state backend, if you specify nothing, is the jobmanager. If 
you wish to establish a different default for all jobs on your cluster, you can 
do so by defining a new default state backend in **flink-conf.yaml**. The 
default state backend can be overridden on a per-job basis, as shown below.
    



> Clarify the effect of configuring per-job state backend 
> --------------------------------------------------------
>
>                 Key: FLINK-6940
>                 URL: https://issues.apache.org/jira/browse/FLINK-6940
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 1.3.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> The documentation of having different options configuring flink state backend 
> is confusing. We should add explicit doc explaining configuring a per-job 
> flink state backend in code will overwrite any default state backend 
> configured in flink-conf.yaml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to