[
https://issues.apache.org/jira/browse/FLINK-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079922#comment-16079922
]
ASF GitHub Bot commented on FLINK-7099:
---------------------------------------
Github user zjureel commented on a diff in the pull request:
https://github.com/apache/flink/pull/4278#discussion_r126343858
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java
---
@@ -91,12 +91,11 @@ public static void submitTopology(final String name,
final Map stormConf, final
final Configuration flinkConfig =
GlobalConfiguration.loadConfiguration();
if (!stormConf.containsKey(Config.NIMBUS_HOST)) {
stormConf.put(Config.NIMBUS_HOST,
-
flinkConfig.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
"localhost"));
+
flinkConfig.getString(JobManagerOptions.ADDRESS, "localhost"));
}
if (!stormConf.containsKey(Config.NIMBUS_THRIFT_PORT)) {
stormConf.put(Config.NIMBUS_THRIFT_PORT,
- new
Integer(flinkConfig.getInteger(ConfigConstants.JOB_MANAGER_IPC_PORT_KEY,
--- End diff --
@zentol Thank you for your review. The default value of
`JobManagerOptions.PORT` is 6123, I think maybe we use
`flinkConfig.getInteger(JobManagerOptions.PORT)` here instead of
`flinkConfig.getInteger(JobManagerOptions.PORT, 6123)` is better. What do you
think? Thanks :)
> Replace usages of deprecated JOB_MANAGER_IPC_PORT_KEY
> -----------------------------------------------------
>
> Key: FLINK-7099
> URL: https://issues.apache.org/jira/browse/FLINK-7099
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, Local Runtime
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Fang Yong
> Fix For: 1.4.0
>
>
> The deprecated {{ConfigConstants#JOB_MANAGER_IPC_PORT_KEY}} is still used a
> lot.
> We should replace these usages with {{JobManagerOptions#PORT}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
