[
https://issues.apache.org/jira/browse/FLINK-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074940#comment-16074940
]
ASF GitHub Bot commented on FLINK-6388:
---------------------------------------
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/3783#discussion_r125677038
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -296,6 +299,39 @@ class CodeGenerator(
fields.mkString(", ")
}
+ def genInitialize(): String = {
+
+ val sig: String =
+ j"""
+ | public void initialize(
+ | org.apache.flink.api.common.functions.RuntimeContext ctx
+ | )""".stripMargin
+
+ val initDist: String = if( distinctAggsFlags.isDefined ) {
+ val statePackage = "org.apache.flink.api.common.state"
+ val distAggsFlags = distinctAggsFlags.get
+ for(i <- distAggsFlags.indices) yield
+ if(distAggsFlags(i)) {
+ val typeString = javaTypes(aggFields(i)(0))
--- End diff --
actually, why shouldn't we use directly rows? is there any specific reason
to prefer tuple?
> Add support for DISTINCT into Code Generated Aggregations
> ---------------------------------------------------------
>
> Key: FLINK-6388
> URL: https://issues.apache.org/jira/browse/FLINK-6388
> Project: Flink
> Issue Type: Sub-task
> Components: DataStream API
> Affects Versions: 1.3.0
> Reporter: Stefano Bortoli
> Assignee: Stefano Bortoli
> Fix For: 1.4.0
>
>
> We should support DISTINCT in Code Generated aggrgation functions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
