Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4146#discussion_r125243142
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -540,7 +526,7 @@ else if (type == NAME_ADDRESSABLE) {
// we should make the local and remote
file deletion atomic, otherwise we might risk not
// removing the remote file in case of
a concurrent put operation
if (blobFile.exists() &&
!blobFile.delete()) {
--- End diff --
you're right, this could be improved as well - the next PR in this series
is removing this code though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
