[ 
https://issues.apache.org/jira/browse/FLINK-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071316#comment-16071316
 ] 

ASF GitHub Bot commented on FLINK-6522:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4204#discussion_r125164914
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/zookeeper/ZooKeeperHaServices.java
 ---
    @@ -190,6 +198,18 @@ public void closeAndCleanupAllData() throws Exception {
                        exception = t;
                }
     
    +           try {
    +                   stateStorage.closeAndCleanupAllData();
    +           } catch (Throwable t) {
    +                   exception = t;
    --- End diff --
    
    add as suppressed exception using `ExceptionUtils.firstOrSuppressed`


> Add ZooKeeper cleanup logic to ZooKeeperHaServices
> --------------------------------------------------
>
>                 Key: FLINK-6522
>                 URL: https://issues.apache.org/jira/browse/FLINK-6522
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Fang Yong
>
> The {{ZooKeeperHaServices}} provide a {{CuratorFramework}} client to access 
> ZooKeeper data. Consequently, all data (also for different job) are stored 
> under the same root node. When 
> {{HighAvailabilityServices#closeAndCleanupAllData}} is called, then this data 
> should be cleaned up. This cleanup logic is currently missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to