[
https://issues.apache.org/jira/browse/FLINK-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067799#comment-16067799
]
ASF GitHub Bot commented on FLINK-6842:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4219
[FLINK-6842] [runtime] Uncomment and activate code in HadoopFileSystem
Uncomment and activate ```getFileSystemClass``` method in HadoopFileSystem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6842
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4219
----
commit 91a7e6a14e827fe1c071fedd6ba3a37c7402b1f4
Author: zhangminglei <zml13856086...@163.com>
Date: 2017-06-29T05:50:51Z
[FLINK-6842] [runtime] Uncomment and activate code in HadoopFileSystem
----
> Uncomment or remove code in HadoopFileSystem
> --------------------------------------------
>
> Key: FLINK-6842
> URL: https://issues.apache.org/jira/browse/FLINK-6842
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: mingleizhang
> Priority: Minor
>
> I've found the following code in
> {{HadoopFileSystem#getHadoopWrapperClassNameForFileSystem}}
> {code}
> Configuration hadoopConf = getHadoopConfiguration();
> Class<? extends org.apache.hadoop.fs.FileSystem> clazz;
> // We can activate this block once we drop Hadoop1 support (only hd2 has the
> getFileSystemClass-method)
> //try {
> // clazz = org.apache.hadoop.fs.FileSystem.getFileSystemClass(scheme,
> hadoopConf);
> //} catch (IOException e) {
> // LOG.info("Flink could not load the Hadoop File system implementation
> for scheme "+scheme);
> // return null;
> //}
> clazz = hadoopConf.getClass("fs." + scheme + ".impl", null,
> org.apache.hadoop.fs.FileSystem.class);
> if (clazz != null && LOG.isDebugEnabled()) {
> LOG.debug("Flink supports {} with the Hadoop file system wrapper, impl
> {}", scheme, clazz);
> }
> return clazz;
> {code}
> Since we don't support hadoop1 anymore the commented code should either be
> activated or removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
