Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4210#discussion_r124705183
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -654,17 +654,23 @@ case class WindowAggregate(
}
// validate property
- if (propertyExpressions.nonEmpty) {
- resolvedWindowAggregate.window match {
- case TumblingGroupWindow(_, _, size) if isRowCountLiteral(size) =>
- failValidation("Window start and Window end cannot be selected "
+
- "for a row-count Tumbling window.")
+ propertyExpressions.foreach {
+ _.child match {
+ case WindowEnd(_) | WindowStart(_) =>
+ resolvedWindowAggregate.window match {
+ case TumblingGroupWindow(_, _, size) if
isRowCountLiteral(size) =>
+ failValidation(
+ "Window start and Window end cannot be selected " +
+ "for a row-count Tumbling window.")
- case SlidingGroupWindow(_, _, size, _) if isRowCountLiteral(size)
=>
- failValidation("Window start and Window end cannot be selected "
+
- "for a row-count Sliding window.")
+ case SlidingGroupWindow(_, _, size, _) if
isRowCountLiteral(size) =>
+ failValidation(
+ "Window start and Window end cannot be selected " +
+ "for a row-count Sliding window.")
- case _ => // ok
+ case _ => // ok
--- End diff --
Can you add a comment here that the `RowtimeAttribute` and
`ProctimeAttribute` should pass ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
