Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4105#discussion_r124574280
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/aggregations.scala
---
@@ -228,12 +228,16 @@ case class VarSamp(child: Expression) extends
Aggregation {
case class AggFunctionCall(
aggregateFunction: AggregateFunction[_, _],
+ resultTypeInfo: TypeInformation[_],
+ accTypeInfo: TypeInformation[_],
args: Seq[Expression])
extends Aggregation {
override private[flink] def children: Seq[Expression] = args
- override def resultType: TypeInformation[_] =
getResultTypeOfAggregateFunction(aggregateFunction)
+ override def resultType: TypeInformation[_] =
getResultTypeOfAggregateFunction(
--- End diff --
should we call `getResultTypeOfAggregateFunction` directly in
`UDAGGExpression.apply()`?
Otherwise, we spread the inference of the function types to several places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
