[
https://issues.apache.org/jira/browse/FLINK-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066692#comment-16066692
]
ASF GitHub Bot commented on FLINK-7025:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4212
[FLINK-7025][table]Using NullByteKeySelector for Unbounded ProcTime N…
…onPartitioned Over
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue
("[FLINK-7025][table]Using NullByteKeySelector for Unbounded ProcTime
NonPartitioned Over")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-7025-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4212
----
commit 37c137547ea6b445b50274297427886fb1c1ae59
Author: sunjincheng121 <sunjincheng...@gmail.com>
Date: 2017-06-28T15:19:56Z
[FLINK-7025][table]Using NullByteKeySelector for Unbounded ProcTime
NonPartitioned Over
----
> Using NullByteKeySelector for Unbounded ProcTime NonPartitioned Over
> --------------------------------------------------------------------
>
> Key: FLINK-7025
> URL: https://issues.apache.org/jira/browse/FLINK-7025
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.3.1, 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Currently we added `Cleanup State` feature. But It not work well if we
> enabled the stateCleaning on Unbounded ProcTime NonPartitioned Over window,
> Because in `ProcessFunctionWithCleanupState` we has using the keyed state.
> So, In this JIRA. I'll change the `Unbounded ProcTime NonPartitioned Over`
> to `partitioned Over` by using NullByteKeySelector. OR created a
> `NonKeyedProcessFunctionWithCleanupState`. But I think the first way is
> simpler. What do you think? [~fhueske]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
