[
https://issues.apache.org/jira/browse/FLINK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066562#comment-16066562
]
ASF GitHub Bot commented on FLINK-7024:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4210
[FLINK-7024][table]Add supported for selecting window proctime/rowtim…
…e on row-based Tumble/Slide window
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue
("[FLINK-7024][table]Add supported for selecting window proctime/rowtime on
row-based Tumble/Slide window")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-7024-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4210
----
commit 512a1b932140dc907175bd9fb43760fe14a793bc
Author: sunjincheng121 <sunjincheng...@gmail.com>
Date: 2017-06-28T14:18:31Z
[FLINK-7024][table]Add supported for selecting window proctime/rowtime on
row-based Tumble/Slide window
----
> Add supported for selecting window proctime/rowtime on row-based
> Tumble/Slide window
> --------------------------------------------------------------------------------------
>
> Key: FLINK-7024
> URL: https://issues.apache.org/jira/browse/FLINK-7024
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> We get validate exception,when selecting window.proctime/rowtime on row-based
> group window.
> {code}
> table
> .window(Tumble over 2.rows on 'proctime as 'w)
> .groupBy('w, 'string)
> .select('string, countFun('string) as 'cnt, 'w.rowtime as 'proctime)
> .window(Over partitionBy 'string orderBy 'proctime preceding
> UNBOUNDED_RANGE following CURRENT_RANGE as 'w2)
> .select('string, 'cnt.sum over 'w2 as 'cnt)
> {code}
> Exception:
> {code}
> org.apache.flink.table.api.ValidationException: Window start and Window end
> cannot be selected for a row-count Tumbling window.
> at
> org.apache.flink.table.plan.logical.LogicalNode.failValidation(LogicalNode.scala:143)
> at
> org.apache.flink.table.plan.logical.WindowAggregate.validate(operators.scala:660)
> {code}
> We should add window.proctime/rowtime check in `validate ` method.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
