[ 
https://issues.apache.org/jira/browse/FLINK-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066543#comment-16066543
 ] 

ASF GitHub Bot commented on FLINK-6358:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4170#discussion_r124547387
  
    --- Diff: 
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/Runner.java
 ---
    @@ -70,7 +79,8 @@
      * <p>Algorithms must explicitly support each type of output via 
implementation of
      * interfaces. This is scalable as the number of outputs is small and 
finite.
      */
    -public class Runner {
    +public class Runner
    +extends ParameterizedBase {
    --- End diff --
    
    why do you extend `ParametrizedBase`? Isn't it intended as a base class for 
parameters? Do you use `Runner` in such context?


> Write job details for Gelly examples
> ------------------------------------
>
>                 Key: FLINK-6358
>                 URL: https://issues.apache.org/jira/browse/FLINK-6358
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> Add an option to write job details to a file in JSON format. Job details 
> include: job ID, runtime, parameters with values, and accumulators with 
> values.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to